Popup menu cleanup #697
Merged
Popup menu cleanup #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
force-pushed
the
popup-menu-cleanup
branch
2 times, most recently
from
aa81b99
to
c2d9344
Compare
smbea
reviewed
Nov 17, 2022
| onKeyup=${ handleKey } | ||
| onKeydown=${ handleKeyDown } | ||
| /> | ||
| ${entry.imageUrl ? html`<img src=${ entry.imageUrl } />` : null} |
There was a problem hiding this comment.
One thing that I found is that we have to be careful with the way we format html template strings. Best practice is to have start and end on separate, individual lines.
Should we not have inline html`` like here then?
There was a problem hiding this comment.
It does not screw up the markup, hence I'd be OK with this snippet.
What breaks the markup entirely is stuff like this:
html`
<div>
<a>...</a>
</div>`
=> Asymetric use of tagged template literal open + close.
Description says component but I guess you meant in the commit description since you moved from the Component to the List |
nikku
force-pushed
the
popup-menu-cleanup
branch
from
16b0616
to
054ce1f
Compare
|
Fixed #697 (comment) via 05ddb4f. |
Scrolling into view can be handled within the <PopupMenuList />
* drop bogus `shouldOpen` handling not available in original menu * use `PopupMenu#trigger` to activate entries
nikku
force-pushed
the
popup-menu-cleanup
branch
from
054ce1f
to
fa7b346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing this PR to address #696 (comment) + minor nit picks (mainly around formatting).
One thing that I found is that we have to be careful with the way we format
htmltemplate strings. Best practice is to have start and end on separate, individual lines:If we approach it like this then we end up with very readable templates, and eslint is happy, too.